fix(inputs.netflow): Decode flags in TCP and IP headers correctly #16248
+20
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aders Golang switch block does not do automatic fallthrough so it must be explicitly added to handle multiple cases
telegraf-tiger
bot
added
fix
…itch statements to if statements fallthrough usage is not valid because next condition is not evaluated
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
|
I have tested the PR build artefact in a real environment and it's working as expected. All flags are decoded and included into the metrics: |
srebhan
changed the title
srebhan
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Thanks a lot for spotting this @joseluisgonzalezca! The contribution is much appreciated!
Could you please also check the other decoders!?!
srebhan
added
the
ready for final review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This problem is present during IPv4 header decoding and TCP header decoding. Both issues have been fixed in this PR.
Golang switch block does not do automatic fallthrough so it must be explicitly added to handle multiple cases
Checklist
Related issues
resolves issue #16247